search

adobe / brackets

An open source code editor for the web, written in JavaScript, HTML and CSS.
http://brackets.io
MIT License
33.25k stars 7.63k forks source link

Unit test failures in native menus #2917

Open njx opened 11 years ago

njx commented 11 years ago

2 consistent failures on the build machine in native menus:

Native Menus getMenuItemState setMenuItemState should be able to set enabled state. Native Menus getMenuItemState setMenuItemState should be able to set checked state.

njx commented 11 years ago

@RaymondLim - assigning to you since Glenn is going to be out, but feel free to reassign if necessary.

gruehle commented 11 years ago

This seems to have fixed itself. I looked at the build machine to see if I could spot anything wrong, but didn't see anything suspicious. The next run of unit tests passed....

RaymondLim commented 11 years ago

Have to close this as utr for now since nothing seems wrong in this specific native menu test file and it no longer reproduces on the build machine.

njx commented 11 years ago

Reopened to sprint 22 since this is happening again.

RaymondLim commented 11 years ago

This seems to be introduced by moving Debug menu to an extension. Debug menu is loaded at a much later time from an extension and it is also inserted after the Window menu instead of before the Window menu. So the menu tests that update menu items may get interrupted by the Debug menu creation.

gruehle commented 11 years ago

Reviewed--marking low priority. The unit tests are disabled for now, and verifying that menus are enabled/checked has been added to the smoke tests.