search

adobe / brackets

An open source code editor for the web, written in JavaScript, HTML and CSS.
http://brackets.io
MIT License
33.26k stars 7.63k forks source link

JavaScript Jump To Definition Ctrl+J/Cmd+J not mentioned in Right-Click Menu #3860

Open petetronic opened 11 years ago

petetronic commented 11 years ago

In any *.js JavaScript source file, right click to see the context menu show:

Quick Edit - Cmd+E Quick Docs - Cmd+K Select All - Cmd+A

It should also show:

Jump To Definition - Cmd+J

jeffkenton commented 11 years ago

I'm looking a this one. (There's some problem actually assigning it to me, but it's mine.)

peterflynn commented 11 years ago

Reviewed.

@adrocknaphobia One issue here is that the menu contents aren't yet selective based on file type. So this would show up in all files, even though it does nothing if you're not in JS code. Should we hold off until we have a better story for truly context-sensitive menus?

Another related point -- Jump to Definition is currently hardcoded to go directly to the JS extension. It's not pluggable in a language-related way, so e.g. a PHP or TypeScript extension would have to add its own separate menu item with the same functionality. We should consider converting the menu item into a more generic extensible hook at some point.

petetronic commented 11 years ago

The menu contents need to be selective based on file type, so we'll hold off on the right click menu - but the hook for other languages sounds useful to address as it shouldn't be tied to JS exclusively.

jeffkenton commented 11 years ago

Both the right-click context menu addition and the Jump-To-Definition navigation menu issue can probably be solved at the same time, using the same technique used by QuickEdit, i.e., registering separate provider functions to handle the various cases.

jeffkenton commented 11 years ago

I have just made a pull request which has Jump-To-Definition added to the right-click menu. It's only one line of code, so we can comment it out at will.

To elaborate: to do this right, we'd want to check the file type (or selection type) every time we displayed the right-click menu, for jump-to-definition, quick edit, etc. We might also want to do the same for the top-level navigate menu. Is this what we plan to do?

redmunds commented 10 years ago

This issue is unassigned, so marking "Needs Review".

disshishkov commented 10 years ago

Guys, there is way to change hotkey from ctrl + j to f12?

dangoor commented 10 years ago

@disshishkov I haven't tried it, but there's a "Brackets Key Remapper" extension (see the extension manager in Brackets)

disshishkov commented 10 years ago

Thank you @dangoor , the mentioned by you extension works great