search

adobe / brackets

An open source code editor for the web, written in JavaScript, HTML and CSS.
http://brackets.io
MIT License
33.25k stars 7.63k forks source link

[Core][ Tab key]: Strange behaviors for tab key in Brackets. #5760

Open julieyuan opened 11 years ago

julieyuan commented 11 years ago

Steps:

  1. Launch Brackets.
  2. Open a project which contains several images.
  3. Click on an image and press Tab key.
  4. Open another project which contains several css files.
  5. Open a html file and put your cursor on a tag, press Ctrl+E to invoke inline editor.
  6. Click the new rule dropdown icon, then press Tab key.
  7. Open a css file and put your cursor on a property name , then press Ctrl +K to invoke Quick Docs editor. While the cursor in in the editor, press Tab key.

Results: In step 3 & 6, it will move down from working files to project tree, then to sidebar when press the Tab key. In step 7, it will move from inline editor to right sidebar, then to left sidebar.

Expected: I don't think Tab key should work as this function in Brackets. When press tab key, nothing should happen.

Notes: I also check these behaviors with Sprint 30. As step 3 & 6 are new feature, so they not reproduce in Sprint30. But step 7 reproduces in Sprint 30.

ENV: MAC 10.8 and Win8.1 English OS Build: 0.33.0-10187

Snapshots: Please refer to snapshots for details: Step3: screen shot 2013-10-30 at 12 40 55 am Step6: 111 Step7: screen shot 2013-10-30 at 12 46 58 am

dangoor commented 11 years ago

Reviewed low priority to @RaymondLim

njx commented 11 years ago

Low priority to @RaymondLim - seems like a number of cases where we need to prevent tab key from setting focus for now. (Eventually, we should consider making the file tree more accessible, but that would be a backlog item.)

RaymondLim commented 10 years ago

@julieyuan Actually, there are three different issues here since each of them needs to be fixed separately. The issue in step 6 is no longer reproducible. So only two issues left. Can you spin off the issue in step 7 to a new issue? It has to be fixed in Quick Doc inline editor after Randy's pull request #6017 landed in master.

julieyuan commented 10 years ago

According to @RaymondLim 's comments above, filed an issue #6150.