adobe / brackets

An open source code editor for the web, written in JavaScript, HTML and CSS.
http://brackets.io
MIT License
33.25k stars 7.63k forks source link

File watching error #6713

Closed marcelgerber closed 10 years ago

marcelgerber commented 10 years ago

I don't know if this was already filed as I didn't follow up the file watchers problems, but this looks serious.

Error: image

Failed to watch root:  C:/Users/Marcel/Documents/GitHub/brackets/ Unable to load one of the modules: C:/Program Files (x86)/Brackets/dev/src/./filesystem/impls/appshell/node/FileWatcherDomain, reason: The specified module could not be found.
C:\Users\Marcel\Documents\GitHub\brackets\src\filesystem\impls\appshell\node\node_modules\fsevents_win\build\Release\fswatch_win.node FileSystem.js:857
Error watching project root:  C:/Users/Marcel/Documents/GitHub/brackets/ Unable to load one of the modules: C:/Program Files (x86)/Brackets/dev/src/./filesystem/impls/appshell/node/FileWatcherDomain, reason: The specified module could not be found.
C:\Users\Marcel\Documents\GitHub\brackets\src\filesystem\impls\appshell\node\node_modules\fsevents_win\build\Release\fswatch_win.node ProjectManager.js:987

The opened project is "brackets" @ C:\Users\Marcel\Documents\GitHub\brackets\, this is the same folder that is used for the "hacked" Brackets version. Win 8.1, Brackets Sprint 35 Shell at 56dc28459

WebsiteDeveloper commented 10 years ago

I also get this on win 7

JeffryBooher commented 10 years ago

@SAPlayer @WebsiteDeveloper I assume you are building the shell in which case you need to delete your deps\node folder and delete release\brackets-node.exeand run grunt setup then grunt. Since this just went in to last night's build we haven't had a chance to put up a Wiki article about this change yet but there is a problem with us renaming node.exe to brackets-node.exe and using node extensions on Windows.

Essentially the new grunt script will copy node.exe without renaming it so theoretical you can just rename brackets-node.exe to node.exe in your release and debug folders but grunt setup is always the safest thing to do because there may be other project file changes that you need as well and grunt setup will build those for you.

marcelgerber commented 10 years ago

No, I haven't ever built brackets-shell myself (I'm still using the one from Brackets Sprint 35).

JeffryBooher commented 10 years ago

ah, you are sync'ing to the lastest master and then loading index.html by holding down shift while starting Brackets. In which case we'll discuss at this morning's standup. We may need to post an interim build of the shell. In either case, the error shouldn't cause Brackets to behave unpredictably, you just won't get file watching on Windows until you get a new version of the shell.

@SAPlayer Has this ever been a problem for you in the past? We've made changes where you need a new shell with the latest master in the past. Just curious how you've resolved those issues in the without building a new shell.

marcelgerber commented 10 years ago

Wrong too, I used tools/setup_for_hacking.bat to "hack" Brackets. I haven't ever had any problems with the shell (haven't looked in the console often, so it could be that there were errors). And I could use every feature I tested without problems, but these are maybe the issues that don't require a new shell build. I haven't tested things like the new FileSystem and the new FileWatchers, that may require a new shell, as I don't know how to test them.

JeffryBooher commented 10 years ago

Right, same thing. The tools/setup_for_hacking.bat just overrides Brackets' default location to load from your git hub repo folder. You can also hold down the shift key to specify the location when launching brackets.

Either way, you should be ok with that build -- Brackets will just be blind to externally modified files until you get the Sprint 36 build installed.

busykai commented 10 years ago

FWIW, the last good commit to be used with the old shell is 49789f5 (left parent of ec17105cb49a1392a625e7c3252ef96bf76bd123). You'll have to branch from there to work on something or build a new shell.

marcelgerber commented 10 years ago

Closing this as it seems it's caused by an outdated brackets-shell version. I will reopen in case I can still repro in Sprint 36 Shell ;)

WebsiteDeveloper commented 10 years ago

@SAPlayer i can verify that it works with a new built shell.

marcelgerber commented 10 years ago

No error message with custom brackets-shell :thumbsup: