search

adobe / brackets

An open source code editor for the web, written in JavaScript, HTML and CSS.
http://brackets.io
MIT License
33.26k stars 7.63k forks source link

[registry] Should have clearer message when file is too large #7076

Open njx opened 10 years ago

njx commented 10 years ago

Currently, if you try to upload a ZIP file that's over our 5MB limit, the registry shows an "invalid ZIP file" error. We should show a real error, and probably also mention the limit somewhere on the page.

njx commented 10 years ago

Medium priority to me. We might just want to raise the limit to 10MB and then lower the priority.

peterflynn commented 10 years ago

See also #6060, which is about considering raising the limit

peterflynn commented 10 years ago

Reviewed - marking for 1.0 now that #6060 is on the back burner

njx commented 10 years ago

Reviewed - leaving on 1.0 list.

njx commented 10 years ago

@dangoor - punting this one to you.

zaggino commented 10 years ago

I have currently 0.4MB file which I cannot upload due to "Invalid zip file" but all the compressing software I tried (7zip, winzip, native ubuntu one) has no problems with it: http://www61.zippyshare.com/v/11279601/file.html

dangoor commented 10 years ago

@zaggino I believe the registry was having a problem on the day that you tried uploading. You might want to try again.

zaggino commented 10 years ago

@dangoor You're right, but more accurate error message like "Unexpected registry problem" would be better than saying "Invalid ZIP file" to the user.

peterflynn commented 10 years ago

Reviewed - reducing to low priority, 1.0