adobe / brackets

An open source code editor for the web, written in JavaScript, HTML and CSS.
http://brackets.io
MIT License
33.26k stars 7.63k forks source link

Control click or click with two fingers on trackpad is not working in the working set. #9350

Open RaymondLim opened 10 years ago

RaymondLim commented 10 years ago
  1. Open some files with JSLint errors in the working set.
  2. Control click on the selected one in the working set to bring up the working set context menu.
  3. Without dismissing the context menu try to control click on another one that has JSLint errors.

Result: The context menu is dismissed and then selection moves to the file you clicked in step 3. Expected: Should dismiss the context menu, switch selection to the file clicked in step 3 and show the context menu on that file. This is the behavior in previous releases and Finder.

Note that you will see the same result if you try with two fingers tap on trackpad,

JeffryBooher commented 10 years ago

On master?

RaymondLim commented 10 years ago

Yes, but I'm seeing some exceptions. For single pane, the topmost one always works correctly. For split views, the second working set seems to work.

RaymondLim commented 10 years ago

I updated steps as the issue only applies to the specific positions in the working set.

RaymondLim commented 10 years ago

It turns out that the two files in the specific positions in my steps have JSLint errors. So updating steps again.

JeffryBooher commented 10 years ago

@RaymondLim I can't make the context menu appear with right click of the mouse using these steps either. Not sure if that's relevant but this probably isn't a show stopper. cmd+click will activate the item as it always has then cmd+clicking again will invoke the menu.

peterflynn commented 10 years ago

Removing Mac-only since I can see this on Windows too (with trackpad right-click, at least). I can also see it in some cases in files without JSLint errors. Oddly, it seems to sometimes vary depending on whether you're selecting an item higher or lower in the list than the previous item.

peterflynn commented 10 years ago

No problems with an actual mouse on Windows for me, though.

JeffryBooher commented 9 years ago

@RaymondLim @peterflynn I can't seem to reproduce this on my Mac Retina on the current Master.

RaymondLim commented 9 years ago

@JeffryBooher I can still reproduce it in master. Are you sure you're doing Control click in step 2 and 3 on files with JSLint errors?

JeffryBooher commented 9 years ago

Yes. The lint panel shows and the context menu appears. I've tried with several files in the working set, with only the one file. I've tried move the file having lint to the top, middle and bottom of the list and CTRL+Click on the trackpad. I've tried 2 fingers down, 1 finger down. All seem to work.

I wonder, though, can you reproduce it with #9610?

RaymondLim commented 9 years ago

@JeffryBooher You need two different files with JSLints to reproduce this issue, not just one file with lint errors. I used Brackets src folder as project root and then open two files from preferences folder.

And I don't see any connection between #9610 and this issue. One has to do with double click inside the editor and this has to do with control click in the working set.

update: I forgot that #9610 is fixing the issue caused by jslint panel.

RaymondLim commented 9 years ago

9610 seems to fix this issue even though it does not fix #9040.

dangoor commented 9 years ago

I can still reproduce this with #9610, though it doesn't reproduce 100% of the time as it seemed to without #9610.

peterflynn commented 9 years ago

In standup we agreed this wasn't critical for 1.1, so removing milestone. It also doesn't appear to be actively being worked on, so removing 'fix in progress' label.