adobe / brackets

An open source code editor for the web, written in JavaScript, HTML and CSS.
http://brackets.io
MIT License
33.29k stars 7.66k forks source link

Only dev/user extension being tested should be loaded in Unit Test windows #9982

Open redmunds opened 9 years ago

redmunds commented 9 years ago

I'm seeing E4B extension in unit test windows:

ut-ext-loaded

peterflynn commented 9 years ago

@redmunds When you have the "Extensions" tab selected, extensions are loaded; otherwise, they're not. You could argue we should split that into dev/user extensions in one tab, and default extensions in a different tab, though...

redmunds commented 9 years ago

Yes, it only happens in Extensions Tab.

marcelgerber commented 9 years ago

Isn't it possible to load just the extension being tested and nothing else?

redmunds commented 9 years ago

This is behaving as designed, but updating title for possible improvement. I think the current mechanism would make this easy to implement.

Only dev/user extension being tested should be loaded in Unit Test windows. Note that default extensions should always be loaded.

peterflynn commented 9 years ago

@MarcelGerber That's possible only if you disable the 'run all' option, which by definition has to load all the extensions. And I assume we want to keep that option.

I still think it would be good to just make this a "User Extensions" tab, and then move core-extension unit tests into the Unit & Integration categories with the other core unit tests. That might require build machine changes though, since I think there's a specific Jenkins job set up to run the "extensions" category.