DINT-1178: Add of 'channel' attribute to all storefront events - Githubissues

adobe / commerce-events

MIT License

6 stars 7 forks source link

DINT-1178: Add of 'channel' attribute to all storefront events #135

Closed NadiyaS closed 9 months ago

NadiyaS commented 10 months ago

Description

Related PR: https://git.corp.adobe.com/magento-datalake/magento2-snowplow-js/pull/245

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

benjaminkalk commented 10 months ago

It looks like every AEP event now needs this channel attribute, as well as the commerce scope set. We should come up with a solution add this information to the event payload without manipulating every handler. One potential solution would be to pass along the Event parameter to the sendEvent function, and include the logic for adding channel info and commerce scope to the payload in that sendEvent function. @aniham and @NadiyaS does that sound reasonable?