search

adobe / create-whisk-action

Node package to automate the repetitive tasks of creating an OpenWhisk action
Apache License 2.0
0 stars 2 forks source link

Consider using package.json `engines` instead of checking for node version in index.js #1

Closed filmaj closed 6 years ago

filmaj commented 6 years ago

Was just a thought ? Perhaps easier than implementing our own version checking?

https://docs.npmjs.com/files/package.json#engines

macdonst commented 6 years ago

@filmaj from the docs:

Unless the user has set the engine-strict config flag, this field is advisory only and will only produce warnings when your package is installed as a dependency.

and engines-strict was removed in npm 3.0.0.

I did a quick test using the engines property and specifying node >= 12 and the package still installed. So I think we are stuck with the way it works now unless I'm missing something.

filmaj commented 6 years ago

Well, then, crap. Closing this down.