adobe / da-admin

Apache License 2.0
0 stars 4 forks source link

Call da-collab back to invalidate and obtain new content if a change originated elsewhere #29

Closed bosschaert closed 4 months ago

bosschaert commented 4 months ago

Description

da-collab is reached via a service binding if configured or otherwise through the address specified in the DA_COLLAB env var.

Note that while with this PR test coverage is going up, as src/routes/source.js is now covered, the computed coverage is down as this has now touched some dependencies which are not (yet) covered. This is a drawback of the way coverage was computed.

Related Issue

Fixes #28

Motivation and Context

It allows the editor to be updated when a change is made on the backend storage. This is also used when restoring a version from the UI.

How Has This Been Tested?

Types of changes

Checklist:

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 88.88889% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 60.55%. Comparing base (844658a) to head (23abfe9).

Files Patch % Lines
src/routes/source.js 88.88% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #29 +/- ## ============================================ - Coverage 100.00% 60.55% -39.45% ============================================ Files 4 13 +9 Lines 221 829 +608 ============================================ + Hits 221 502 +281 - Misses 0 327 +327 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.