GH-35 - Self-service Authentication - Githubissues

adobe / da-admin

Apache License 2.0

0 stars 4 forks source link

GH-35 - Self-service Authentication #36

Closed auniverseaway closed 3 months ago

auniverseaway commented 4 months ago

Ability to use /config to setup admin.role.all.
Org performance improved by creating an orgs key (index) in DA_AUTH.
Org / bucket check now only happens when org or repo is being POSTed. Middleware and index check / udpate will not be added if split path is longer than 2.

Resolves: GH-35

How to test

Visit: https://main--da-live--adobe.hlx.page/?da-admin=stage
Notice faster listing of orgs (down from 2s+ to < 1s)
Select a test org
Select config icon in breadcrumb
Add:

key            | value
admin.role.all | youremail@youremail.com

Notice that if you re-visit (with the stage query param) in a private window, the org will not be visible.

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] I have signed the Adobe Open Source CLA.
[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[X] I have added tests to cover my changes.
[X] All new and existing tests passed.

Release notes

Authentication is now self service using the config view.
Org list performance improvements by creating an index. Cutting response times from 2.5s+ to ~500ms.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.03%. Comparing base (6b1cb87) to head (f4b1fd6).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #36 +/- ## =========================================== + Coverage 63.24% 77.03% +13.78% =========================================== Files 14 14 Lines 887 897 +10 =========================================== + Hits 561 691 +130 + Misses 326 206 -120 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.