Remove PATCH API as its not needed

adobe / da-admin

Apache License 2.0

0 stars 4 forks source link

Remove PATCH API as its not needed #53

Closed bosschaert closed 2 months ago

bosschaert commented 3 months ago

Description

The UI functionality using the PATCH API didn't make it so we can remove it.

Related Issue

Fixes: #52

Motivation and Context

It's a cleanup.

How Has This Been Tested?

Unit tests

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] I have signed the Adobe Open Source CLA.
[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[X] I have added tests to cover my changes.
[X] All new and existing tests passed.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.72%. Comparing base (a6a6ea7) to head (3624fa8).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #53 +/- ## ========================================== - Coverage 83.64% 82.72% -0.92% ========================================== Files 15 14 -1 Lines 960 909 -51 ========================================== - Hits 803 752 -51 Misses 157 157 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bosschaert commented 3 months ago

Note that the coverage reduction is purely caused by the fact that this commit removes code, so the previously uncovered code now takes a larger percentage.