adobe / da-admin

Apache License 2.0
0 stars 4 forks source link

Include coverage for all source files #58

Closed bosschaert closed 2 months ago

bosschaert commented 2 months ago

Description

Previously coverage figures were only on source files touched by unit tests, which meant that if you added tests to a previously untested sourcefile, it would typically bring the overall coverage down, unless that new file was immediately close to 100% covered.

This change computes coverage figures on all source files, which is more truthful.

It will seriously bring the coverage figure down, but the new coverage figure is the correct one.

Also updated .nycrc.json to accept the current figure as the minimum one.

Types of changes

A build system fix. No change to the actual product code.

Checklist:

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.08%. Comparing base (48867b1) to head (2cc1d06).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #58 +/- ## =========================================== - Coverage 82.72% 47.08% -35.64% =========================================== Files 14 35 +21 Lines 909 1597 +688 =========================================== Hits 752 752 - Misses 157 845 +688 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.