adobe / da-admin

Apache License 2.0
1 stars 6 forks source link

GH-79 Copy and delete performance #90

Open bstopp opened 22 hours ago

bstopp commented 22 hours ago

Description

Copy & Delete now return a specific status code based on resulting state:

Copy Operation will return a list of remaining Keys that need to be updated. If present, will not query system again, will just operate on the list. If still more remain after sub-process limit is reached, repeat the call via client.

Delete operation can simply be called again and again until a 204 response is returned.

Related Issue

Fixes #79

How Has This Been Tested?

Added unit tests, also added functional/integration test as expected by browser.

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 22 hours ago

Codecov Report

Attention: Patch coverage is 86.56716% with 9 lines in your changes missing coverage. Please review.

Project coverage is 56.15%. Comparing base (e407d91) to head (926cab1).

Files with missing lines Patch % Lines
src/helpers/copy.js 0.00% 5 Missing :warning:
src/storage/object/delete.js 88.57% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #90 +/- ## ========================================== + Coverage 53.64% 56.15% +2.50% ========================================== Files 38 38 Lines 1795 1820 +25 ========================================== + Hits 963 1022 +59 + Misses 832 798 -34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.