adobe / da-live

Dark Alley is a research project
https://da.live
Apache License 2.0
7 stars 11 forks source link

aem2doc parsing now done in da-collab #163

Closed bosschaert closed 1 month ago

bosschaert commented 1 month ago

Also cleans up old websockets on navigation

Description

da-collab now does its own aem2doc and vice versa parsing. This PR is to accommodate this on the client side.

It also contains a bugfix to close the current websocket if the client navigates to a different document.

Related Issue

This is the client-side change for https://github.com/adobe/da-collab/pull/38

How Has This Been Tested?

Types of changes

Checklist:

aem-code-sync[bot] commented 1 month ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [f8f4417](https://github.com/adobe/da-live/commit/f8f44178435dc9eef9dc3f576c4e48941223aa87) :white_check_mark: (latest) * [2bdf459](https://github.com/adobe/da-live/commit/2bdf45988fe3af73ccf2071e5297c804d8cee360) :white_check_mark: * [41ba5a5](https://github.com/adobe/da-live/commit/41ba5a5bd0e4684e05a6ab13c12224bd36621091) :white_check_mark: * [ec8c88f](https://github.com/adobe/da-live/commit/ec8c88f5639b2d60cf643dd31ff44286c70567f0) :white_check_mark:
bosschaert commented 1 month ago

The Playwright tests should start parsing once https://github.com/adobe/da-collab/pull/38 is merged.