Fix editing multi-sheets

adobe / da-live

Dark Alley is a research project

https://da.live

Apache License 2.0

7 stars 11 forks source link

Fix editing multi-sheets #183

Closed bosschaert closed 2 weeks ago

bosschaert commented 1 month ago

Description

Editing existing multi-sheets (spreadsheets that contain more than 1 sheet) is currently broken. This fixes it.

Test URLs: Before: https://da.live/sheet#/da-sites/da-status/bosschae/data/tags After: https://multi-sheet--da-live--adobe.hlx.live/sheet#/da-sites/da-status/bosschae/data/tags

Related Issue

Fixes: #182

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] I have signed the Adobe Open Source CLA.
[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[X] I have added tests to cover my changes.
[X] All new and existing tests passed.

aem-code-sync[bot] commented 1 month ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

[ ] Re-run PSI checks
[ ] Re-sync branch

Commits

* [c8bc801](https://github.com/adobe/da-live/commit/c8bc8011361a4735f54975d2efe6032c3bb2e0bd) :white_check_mark: (latest) * [279e51d](https://github.com/adobe/da-live/commit/279e51d296460018da2d458c3368ade9e25b368f) :white_check_mark: * [a16a463](https://github.com/adobe/da-live/commit/a16a46341e3f7da25f773381ccf352e46d17d5bb) :white_check_mark:

bosschaert commented 1 month ago

The PW tests are not very reliable when run in the GH action. They are when run from my machine, but this needs to be looked at which I will do separately.