Playwright test stability

bosschaert commented 1 month ago

Description

Stabilize the Playwright tests

Motivation and Context

Especially in the context of GH actions the PW tests are sometimes flaky.

The GH actions are run in a single core context which means that the browser runtimes run by PW have less cycles to catch up with any changes that are happening asynchronously. To give the browsers a little more time a few extra wait moments have been added to the tests.

How Has This Been Tested?

These are tests

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] I have signed the Adobe Open Source CLA.
[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[X] I have added tests to cover my changes.
[X] All new and existing tests passed.

aem-code-sync[bot] commented 1 month ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

[ ] Re-run PSI checks
[ ] Re-sync branch

Commits

* [dc4a14f](https://github.com/adobe/da-live/commit/dc4a14f32f74b26c05f01d3751d77c755a1fa168) :white_check_mark: (latest) * [7059fa6](https://github.com/adobe/da-live/commit/7059fa6aa5020fb5b763eaff56539227198cc7a7) :white_check_mark: * [5df72b5](https://github.com/adobe/da-live/commit/5df72b5dc3a5f6d39febd453c92ca124f0a38d38) :white_check_mark: * [3ee094f](https://github.com/adobe/da-live/commit/3ee094fb2362e959137d513b08c477bada35c5be) :white_check_mark: * [8170520](https://github.com/adobe/da-live/commit/817052090b52a948315e1a67cc0e9b4d17fee273) :white_check_mark: * [a20147a](https://github.com/adobe/da-live/commit/a20147abffeba1fcc19ffb1c59028a07f088e593) :white_check_mark:

bstopp commented 1 month ago

Side note: i think .spec. is a Ruby convention? .test. is Node's convetion

bosschaert commented 1 month ago

Side note: i think .spec. is a Ruby convention? .test. is Node's convetion

Yes right, and our unit tests use .test. but the Playwright convention seems to be to use .spec. so that's what I followed, see here https://playwright.dev/docs/writing-tests and a .js specific use-case https://www.lambdatest.com/learning-hub/playwright-javascript

adobe / da-live