adobe / da-live

Dark Alley is a research project
https://da.live
Apache License 2.0
7 stars 11 forks source link

Links on Images not currently working in DA #194

Open treeves opened 4 weeks ago

treeves commented 4 weeks ago

Expected Behaviour

Adding a link to an image should result in an tag wrapping the image.

Actual Behaviour

Links are being stripped and don't make it out to the preview or live hlx pages.

Reproduce Scenario (including but not limited to)

See https://da.live/edit#/jmphlx/jmp-da/0-sandbox/craig-test/modal-play-button-test

and https://main--jmp-da--jmphlx.hlx.live/0-sandbox/craig-test/modal-play-button-test

Link wrapped on the play button (or ANY image) should allow for a clickable link, but no sign of the link or alt shows up in the generated HTML

Steps to Reproduce

See above

Platform and Version

Browser (any)

Sample Code that illustrates the problem

For https://main--jmp-da--jmphlx.hlx.page/0-sandbox/tad-test/video-test / https://da.live/edit#/jmphlx/jmp-da/0-sandbox/tad-test/video-test

The generated HTML is only:

Test

--   |

  |   |   |   |   |   |

Logs taken while reproducing problem

None

bosschaert commented 3 weeks ago

It looks like this is caused by https://github.com/yjs/y-prosemirror/issues/165

auniverseaway commented 3 weeks ago

Fixed with #199.