Fix playwright tests - Githubissues

adobe / da-live

Document Authoring is an early-access technology preview from Adobe.

https://da.live

Apache License 2.0

10 stars 12 forks source link

Fix playwright tests #215

Closed bosschaert closed 2 months ago

bosschaert commented 2 months ago

Description

Fix the Playwright tests

Related Issue

The playwright tests were failing because of a change in the layout.

How Has This Been Tested?

These are tests

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] I have signed the Adobe Open Source CLA.
[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[X] I have added tests to cover my changes.
[X] All new and existing tests passed.

aem-code-sync[bot] commented 2 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

[ ] Re-run PSI checks
[ ] Re-sync branch

Commits

* [8d8d833](https://github.com/adobe/da-live/commit/8d8d833cb40bf8ec703c8e751ecd27b6e2b5170e) :white_check_mark: (latest) * [4399c8c](https://github.com/adobe/da-live/commit/4399c8c6acbb99c91bcfc73391813adc377ef94d) :white_check_mark: * [a406a8e](https://github.com/adobe/da-live/commit/a406a8e4a3da0c37ce3c336707888a3a8dc18685) :white_check_mark:

bosschaert commented 2 months ago

I fixed the delete test and copy-rename tests, but the regionaledit test is still failing at this point:

Locator: locator('div.loc-color-overlay.loc-langstore')
    Expected: visible
    Received: hidden
    > 25 |   await expect(page.locator('div.loc-color-overlay.loc-langstore')).toBeVisible();

which is strange because I can see it when stepping through it.

@chrischrischris since you wrote this test, do you know why it started failing?

bosschaert commented 2 months ago

Playwright tests are fixed now.

The unit tests are still failing due to some date formatting issue. I'll file a separate PR for that 😄