Fix two failing playwright tests

bosschaert commented 1 month ago

Description

The following playwright tests are failing on main:

Copy and Rename with Versioned document
Create Delete Document

Details about why they failed:

Copy and Rename with Versioned document

A button selector had to be made more specific as another button selector of the same class is now appearing. This might be timing related and was a flaw in the test

Create Delete Document

An second browser window was still open during the execution of the test which cause a deleted file to be re-written. This was a flaw in the test.

General

Additionally, the directory listing is not updated with the deleted item removed, this might be caused by the same issue causing #233. It only gets updated on an extra reload of the page but the item is actually deleted. I've added these reloads for these for now, but we should remove those once #233 is fixed.

Test URLs:

Main: https://main--da-live--adobe.hlx.live/
Branch: https://fix-pwtests--da-live--adobe.hlx.live/

How Has This Been Tested?

These are tests.

Also added some linter instructions (comments) to some non-test files that caused the build to fail because the linter complained.

Types of changes

Only changes to the PW tests.

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] I have signed the Adobe Open Source CLA.
[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[X] I have added tests to cover my changes.
[X] All new and existing tests passed.

aem-code-sync[bot] commented 1 month ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

[ ] Re-run PSI checks
[ ] Re-sync branch

Commits

* [9416adc](https://github.com/adobe/da-live/commit/9416adc8091be69f944d1cf69099c35fd250edeb) :white_check_mark: (latest) * [923126a](https://github.com/adobe/da-live/commit/923126a1943b1a692c135ce8b4293b37c0ff13ba) :white_check_mark: * [07c9f9a](https://github.com/adobe/da-live/commit/07c9f9a1beea40bffc06ad3da71fd55a12859085) :white_check_mark: * [5b6658f](https://github.com/adobe/da-live/commit/5b6658f609c1fb3b89aa76d8d7d234d34b0a9128) :white_check_mark:

aem-code-sync[bot] commented 1 month ago

	Page	Scores	Audits	Google
:iphone:	/
:desktop_computer:	/

adobe / da-live