search

adobe / ferrum

Features from the rust language in javascript: Provides Traits/Type classes & a hashing infrastructure and an advanced library for working with sequences/iterators in js
https://www.ferrumjs.org
Apache License 2.0
516 stars 25 forks source link

Use Adobe Bot Credentials for Semantic Release #5

Closed tripodsan closed 5 years ago

tripodsan commented 5 years ago

@trieloff Can you please add the proper config in circle CI ? thanks.

tripodsan commented 5 years ago

Actually, I just realized that the package is released without the @adobe/ scope. @trieloff @koraa Should we move it there?

Alternatively, @koraa can add the adobe bot (adobe-admin <grp-opensourceoffice@adobe.com>) as owner to the package:

$ npm owner ls ferrum
korra <npmjs.karo@cupdev.net>

see https://docs.npmjs.com/cli/owner

trieloff commented 5 years ago

@koraa I'd be +1 with renaming it to @adobe/ferrum and I'll copy the tokens in CircleCI right away.

trieloff commented 5 years ago

GH_TOKEN and NPM_TOKEN have been set up.

koraa commented 5 years ago

I'd prefer using the plain ferrum name, since it's a fairly generic library; although I would like to transfer the name to the adobe users, it's just on my account since I had to have the name transferred from an old, stale project…

npm add owner adobe-admin
npm remove owner koraa

Is this correct?

@tripodsan Not sure how to create the circleci config; do I even have the necessary credentials? Could you please go ahead and open a PR for a circleci setup? :)

Shoot, accidentally clicked close…

tripodsan commented 5 years ago

npm add owner adobe-admin npm remove owner koraa

I wouldn't remove your own user...otherwise we're only left with the bot account...which might be a problem. @trieloff I think it's also possible to add the entire helix team, right?

eg. when I do a 

$ npm owner ls @adobe/helix-simulator

I see many users - and I dont think they we all added indicidually.

koraa commented 5 years ago

I think (not quite sure, $ npm owner ls isn't up to date yet) I've added adobe-admin; I've also added tripod, trieloff and rofe for truck factor reduction. Not sure if I should add all the other names; seems like a lot…I could write a script of course…

tripodsan commented 5 years ago

hmm, so far I see:

$ npm owner ls ferrum
korra <npmjs.karo@cupdev.net>
rofe <npm@rofe.com>
trieloff commented 5 years ago

Helix Simulator is part of the @adobe namespace, so anyone in the NPM Adobe org is a collaborator, which I think is the right way to go

koraa commented 5 years ago

@tripodsan Probably needs some time to become active…