search

adobe / franklin-dashboard

Apache License 2.0
4 stars 2 forks source link

merge styles, new blocks, tweaks to OOTB blocks and a few global js updates #18

Closed langswei closed 11 months ago

langswei commented 11 months ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Merging various styling and new blocks. There are a few to-dos to be aware of that we need to work through, specifically:

echarts 5.0 is lazy loaded and echarts 5.4.2 is delayed loaded. This was the only way to have output from both Marquise and I to work. The pages work loading both versions (surprisingly) but do not hit 100 LHS. I believe once echarts 5.0 is removed from lazy loading and only 5.4.2 delayed is used instead, it will enable 100 LHS. However, additional development tasks (in scripts.js I think) will have to be done by Marquise to make this happen because simply removing those 5.0 lines from scripts.js left a broken site.

Once we have a functional, LHS 100 site using the newer echarts with delayed loading, I suggest the following in order make pages look more consistent:

Test URLs:

Before: https://main--franklin-dashboard--adobe.hlx.page/ After: https://main--franklin-dashboard--adobe.hlx.page/

aem-code-sync[bot] commented 11 months ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

langswei commented 11 months ago

See site at https://damian06--franklin-dashboard--adobe.hlx.live and provide domainkey and url. Requires some manual URL manipulation to view different pages until we get our navigability corrected.

langswei commented 11 months ago

I'm going to close this PR and open a new one with test URLs from the beginning per slack discussion with Amol in #franklin-dashboard-internal. This is an attempt to prevent domainkeys from being written by helix-bot.