load echarts conditionally

adobe / franklin-dashboard

Apache License 2.0

4 stars 2 forks source link

load echarts conditionally #30

Closed langswei closed 9 months ago

langswei commented 9 months ago

Allow pages to not load echarts when not needed. A metadata block on the page with a tag named echarts and value of false is all that is needed

Fix #27

Test URLs:

Before: https://datalist--franklin-dashboard--adobe.hlx.live/screens/experimental/no-echarts
After: https://datalist-echartsoptional--franklin-dashboard--adobe.hlx.live/screens/experimental/no-echarts

aem-code-sync[bot] commented 9 months ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

[ ] Re-run PSI Checks

aem-code-sync[bot] commented 9 months ago

Page	Scores	Audits	Google
/screens/experimental/no-echarts