search

adobe / franklin-dashboard

Apache License 2.0
4 stars 2 forks source link

Ad-Hoc Lighthouse Score test #4

Open meryllblanchet opened 1 year ago

meryllblanchet commented 1 year ago

In the top domain pages view (see #3 ), I want to be able to trigger a lab check (LHS test) and get the Lighthouse Score for Performance, Best Practices, Accessibility and SEO for any listed page.

langswei commented 11 months ago

Expanding on Meryll's idea above, another good POC would be daily collection and storage of Lighthouse scores, perhaps for the top path per domain. The gap between core web vitals and Lighthouse is becoming more evident, and going through a recent research exercise has highlighted that we do not keep historic Lighthouse data.

@MarquiseRosier you wrote something to crawl third-party data and store in BigQuery related to PRs. Might we be able to POC something like that for Lighthouse? This would be in addition to ad hoc, any path checks.

MarquiseRosier commented 11 months ago

^^ absolutely, we have query-index to each helix-page I believe; we can get the list; and crawl the relative paths, then send them to lighthouse on a daily basis; or make it a part of helix-bot to do this work.

@trieloff any thoughts on this :)

@langswei i might disagree on this a bit; and think cwv are a subset of lighthouse and give us most of the info we need to have good lighthouse, which is why when we focus on our CWV we have good lighthouse scores. But the more info we have the merrier in my opinion! Maybe i'm misunderstanding, if you'd care to explain more!

trieloff commented 11 months ago

I think a LH Snapshot database could be a good thing to have. If we model this after the rotate-domainkey query, we could build the persistence quite easily.