adobe / franklin-dashboard

Apache License 2.0
4 stars 2 forks source link

Remove leading https:// from url param #43

Closed langswei closed 7 months ago

langswei commented 7 months ago

Expected Behaviour

If a user enters https:// before the hostname in either the home screen or via the filter block at the top of each page, the query should still work. While working in the filter, it would make sense to make the URL field longer so that the truncation appearance is not so severe.

Actual Behaviour

No matches are found with https:// prefix in the dashboard.

Reproduce Scenario (including but not limited to)

Steps to Reproduce

This returns data: https://main--franklin-dashboard--adobe.hlx.live/views/rum-dashboard?domainkey=8e884fda-f644-4708-b583-a4b0715068cd&url=www.hlx.live

This does not return data: https://main--franklin-dashboard--adobe.hlx.live/views/rum-dashboard?domainkey=8e884fda-f644-4708-b583-a4b0715068cd&url=https://www.hlx.live

Note the difference in url param.

Platform and Version

Sample Code that illustrates the problem

Logs taken while reproducing problem

langswei commented 7 months ago

Possible approaches are to:

Probably the second option is the easiest.