fix no result skeleton logic

adobe / franklin-dashboard

Apache License 2.0

4 stars 2 forks source link

fix no result skeleton logic #53

Closed dbrrt closed 3 months ago

dbrrt commented 4 months ago

This PR fixes display logic of No result of 404 report page. If this approach is approved, to be integrated in other chart views.

Fix #52

https://fix-skeleton-no-result-logic--franklin-dashboard--adobe.hlx.page/

aem-code-sync[bot] commented 4 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

[ ] Re-run PSI checks
[ ] Re-sync branch

Commits

* [922958d](https://github.com/adobe/franklin-dashboard/pull/53/commits/922958d82d10afe4a659ee3ec8d40ed5ab0a95f9) :x: (latest) * [b2395f6](https://github.com/adobe/franklin-dashboard/pull/53/commits/b2395f6c1d64cd3f68750c49a4db1b92311ea6ee) :x:

aem-code-sync[bot] commented 4 months ago

Page	Scores	Audits	Google
/

dbrrt commented 4 months ago

There're some linting issues not related to the PR. I can recommend to install ESlint extension in the IDE (e.g.: VScode) to automatically fix most eslint trivial issues.

dbrrt commented 3 months ago

Closing for now as this issue can be solved generically and is trivial