Address no data glitch issue

adobe / franklin-dashboard

Apache License 2.0

4 stars 2 forks source link

Address no data glitch issue #65

Open dbrrt opened 3 months ago

dbrrt commented 3 months ago

Fix #52

https://main--franklin-dashboard--adobe.hlx.page/

aem-code-sync[bot] commented 3 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

[ ] Re-run PSI checks
[ ] Re-sync branch

Commits

* [c056541](https://github.com/adobe/franklin-dashboard/pull/65/commits/c056541ea534f7d7b1445e696bdbc40dffa36d3f) :white_check_mark: (latest) * [7eac8ce](https://github.com/adobe/franklin-dashboard/pull/65/commits/7eac8ce94dd3e4b74d4e0683266b790ab3f88bdb) :white_check_mark:

dbrrt commented 2 months ago

Can you update this PR to ensure Progress Bar Component stays until the data replaces it? :) That's about the only change needed here for me to approve because I'm sure people will complain about the blank screen with no indication of the fact that data is loading!

My thought on this issue is that it was related to how "fetching" to passed to children components, so not something that can be addressed directly, but instead fixing how fetching is being integrated via props.