adobe / franklin-dashboard

Apache License 2.0
4 stars 2 forks source link

New404 #90

Closed langswei closed 3 weeks ago

langswei commented 4 weeks ago

404 report was misleading because it could result in a URL with seemingly more 404s than views. We changed the query to group the results in a more intuitive way. The new query will report fewer or equal 404s compared to page views for a given URL, and potentially more URLs depending on the data.

Fix #66

Test URLs: use the params found at https://cq-dev.slack.com/archives/C04MQCRHLBY/p1710254256141179

aem-code-sync[bot] commented 4 weeks ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [4daa3c0](https://github.com/adobe/franklin-dashboard/commit/4daa3c0d881706b38e3cb3910c8ec47fa0753237) :white_check_mark: (latest) * [c58ab4a](https://github.com/adobe/franklin-dashboard/commit/c58ab4a961dafe0145655d614a93b806c6a5f5ca) :white_check_mark: * [80ffa51](https://github.com/adobe/franklin-dashboard/commit/80ffa51c087ee43b59828fd33c3058f37fa1c7b4) :white_check_mark: * [45ce5d5](https://github.com/adobe/franklin-dashboard/commit/45ce5d54225c3b005c1d3d04d47abf2c9936c71b) :white_check_mark:
aem-code-sync[bot] commented 4 weeks ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
langswei commented 3 weeks ago
  1. can we (or should we) switch from v3/rum-sources to v3/rum-404 for the spacecat 404 reporting?

I think it would be best for spacecat to switch, for consistency purposes.

  1. would it be too hard to include all the sources in the response of v3/rum-404 on top of "top source"?

@ekremney Are you asking to include the additional info in the run-query but not the dashboard, or in both the run-query and the dashboard?

ekremney commented 3 weeks ago

@ekremney Are you asking to include the additional info in the run-query but not the dashboard, or in both the run-query and the dashboard?

@langswei only in the run-query. Then any UI/outlet which consumes this query can decide themselves whether to show only the "top source" or all sources

langswei commented 3 weeks ago

@ekremney Are you asking to include the additional info in the run-query but not the dashboard, or in both the run-query and the dashboard?

@langswei only in the run-query. Then any UI/outlet which consumes this query can decide themselves whether to show only the "top source" or all sources

In that case lets move the discussion to the helix-run-query repo so I can merge this change. @MarquiseRosier upon your approval I will merge.