Closed langswei closed 3 weeks ago
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.
Page | Scores | Audits | |
---|---|---|---|
/ |
- can we (or should we) switch from
v3/rum-sources
tov3/rum-404
for the spacecat 404 reporting?
I think it would be best for spacecat to switch, for consistency purposes.
- would it be too hard to include all the sources in the response of
v3/rum-404
on top of"top source"
?
@ekremney Are you asking to include the additional info in the run-query but not the dashboard, or in both the run-query and the dashboard?
@ekremney Are you asking to include the additional info in the run-query but not the dashboard, or in both the run-query and the dashboard?
@langswei only in the run-query. Then any UI/outlet which consumes this query can decide themselves whether to show only the "top source" or all sources
@ekremney Are you asking to include the additional info in the run-query but not the dashboard, or in both the run-query and the dashboard?
@langswei only in the run-query. Then any UI/outlet which consumes this query can decide themselves whether to show only the "top source" or all sources
In that case lets move the discussion to the helix-run-query repo so I can merge this change. @MarquiseRosier upon your approval I will merge.
404 report was misleading because it could result in a URL with seemingly more 404s than views. We changed the query to group the results in a more intuitive way. The new query will report fewer or equal 404s compared to page views for a given URL, and potentially more URLs depending on the data.
Fix #66
Test URLs: use the params found at https://cq-dev.slack.com/archives/C04MQCRHLBY/p1710254256141179