adobe / franklin-dashboard

Apache License 2.0
4 stars 2 forks source link

feat: prevent commas in url and use same origin for run-query #94

Closed langswei closed 1 week ago

langswei commented 2 weeks ago

With the completion of https://github.com/adobe/helix-run-query/pull/1092 we wanted to restrict the multiple domains feature from the dashboard UI until the queries have more exercise and clarity on impact.

Test URLs:

Enter a comma-separated string of urls in both the main entry form as well as the left nav filter once in. Notice that in both cases only the first url is kept. Also notice that a single url works the same as before - no regression.

Also notice that data.aem.live is now the host for run-query calls instead of helix-pages.anywhere.run.

Minor lint adjustments included.

aem-code-sync[bot] commented 2 weeks ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [ea1c998](https://github.com/adobe/franklin-dashboard/commit/ea1c9984358f1ac0a47e44ac8ef3d5f391688f39) :white_check_mark: (latest) * [76f3974](https://github.com/adobe/franklin-dashboard/commit/76f3974e2c1222273ab110355cd744925869d5a5) :white_check_mark:
aem-code-sync[bot] commented 2 weeks ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI