search

adobe / generator-add-action-asset-compute

An Asset Compute action that can be added to an App Builder app as a template
Other
0 stars 3 forks source link

fix: update aio-cli-plugin-asset-compute v4.0.2 #3

Closed shazron closed 1 year ago

shazron commented 2 years ago

Description

Updates the asset-compute plugin to v4, by two major versions. Therefore this module needs to be updated by a major version as well, when released.

Do not merge, until v4 version of the asset-compute plugin has been thoroughly tested.

Dependents:

  1. https://github.com/adobe/generator-app-asset-compute
  2. https://github.com/adobe/generator-aio-app

^^ the above will need major version updates as well, which in turn will require a minor version update in aio-cli-plugin-app: https://github.com/adobe/aio-cli-plugin-app/blob/70b9a426c7972c20cced304254d4c84c73fcd78a/package.json#L18

To test:

  1. aio app init my-app -e dx/asset-compute/worker/1
  2. cd my-app
  3. npm i @adobe/aio-cli-plugin-asset-compute@4
  4. aio app test

How Has This Been Tested?

Manual testing via the steps above. Requires this change: https://github.com/adobe/generator-app-asset-compute/commit/d73ad0fbc17bd90acf54d8231994ebe91a05d7c5

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #3 (eda9a3f) into main (ed6dfef) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##              main        #3   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           15        15           
=========================================
  Hits            15        15
Impacted Files Coverage Δ
index.js 100.00% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more