search

adobe / generator-aio-app

Yeoman generator for a new Adobe I/O App
https://www.adobe.io
Apache License 2.0
12 stars 21 forks source link

Githib Action Workflows does not read API key from secrets #112

Open PulkitXChadha opened 3 years ago

PulkitXChadha commented 3 years ago

Expected Behaviour

While deploying an app in Stage and prod the GitHub action should deploy a functioning app in stage and production.

Actual Behaviour

The CI/CD of the firefly app with GitHub actions does not deploy the app with an API key. The app fails with 'api key' missing error below "error": "missing parameter(s) 'apiKey'"

Reproduce Scenario (including but not limited to)

Steps to Reproduce

Deploy an app in Stage or production using GitHub actions CI/CD flow.

Platform and Version

Sample Code that illustrates the problem

Logs taken while reproducing problem

meryllblanchet commented 3 years ago

Thanks for the proposal, @PulkitXChadha !

In the short-term, please follow the example in our codelab to update the bootstrapped GH workflows inside your application code with additional GH secrets that you will have to manually add to your repository.

On the longer run, we'll provide additional CI/CD features that will help automate such scenarios.

aiojbot commented 3 years ago

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-952