search

adobe / generator-app-asset-compute

Extensibility template for Asset Compute, for App Builder
Apache License 2.0
0 stars 8 forks source link

extension keys must be tied to explicit versions #46

Open purplecabbage opened 7 months ago

purplecabbage commented 7 months ago

Description

This command was broken by publishing a new latest version of this module, even though it was a major version.

aio app:init --no-login -i ../../test/console.json -e dx/asset-compute/worker/1

dx/asset-compute/worker/1 used to mean @adobe/generator-app-asset-compute@1.0.2

but now it results in: @adobe/generator-app-asset-compute@2 which may not be compatible.

Workaround

Use: --template @adobe/generator-app-asset-compute@1.0.2 instead of the --extension flag.

Fix

We need to decide if a new major of a template generator should also mean a new extension registry key.
Should dx/asset-compute/worker/1 => @adobe/generator-app-asset-compute@1 and dx/asset-compute/worker/2 => @adobe/generator-app-asset-compute@2

aiojbot commented 7 months ago

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-2721

shazron commented 7 months ago

We can possibly also fix it in the Template Registry. By design the Template Registry always checks daily for the latest version of a template and updates it in the registry. We would have to propose a new feature somehow tying extension points to certain template versions -- there is no way to do this right now via the standard mechanisms.

Since the Template Registry version check is via the latest dist-tag on npm (via npm view PACKAGE_NAME version), we could always point to v1.0.2 as latest for now until we get it sorted.