search

adobe / helix-cli

Command-line tools for developing with AEM
Apache License 2.0
49 stars 58 forks source link

Reverse proxy has the branch hardcoded to main #2362

Closed clementepereyra closed 3 months ago

clementepereyra commented 3 months ago

Description The client always uses the main branch for the reverse proxy. Even though locally we are working on a separate branch, there's a hardcoded value to use main always. I've seen this has been added here as part of a fix. But I think that's preventing working with any other branch but main while working on local development.

To Reproduce Steps to reproduce the behavior:

  1. Install the client.
  2. Clone a repository based on the AEM boilerplate template.
  3. Create a new branch, push it and check it out.
  4. Run aem up.
  5. See that even though you are on a different branch, the client still works with main branch

Expected behavior The client should create the reverse proxy based on the git branch currently in use.

Screenshots

image image

Version: 16.3.16

tripodsan commented 3 months ago

yes. this was changed in https://github.com/adobe/helix-cli/pull/2333

if you want to open a specific branch, use the --url argument or the AEM_URL env var. mainly to address: https://github.com/adobe/helix-cli/issues/2331

clementepereyra commented 3 months ago

Thanks for the response @tripodsan. That's exactly right, it was introduced in there. So, are you saying this was intentional and the idea is to limit the client to only pull from main? Meaning, this is not a defect but a desired feature?