Consistent suffix within context - Githubissues

adobe / helix-deploy

A multi-cloud deployment tool for serverless functions running on AWS Lambda, Adobe I/O Runtime, Azure Functions, and Google Cloud Functions. Write once, run everywhere.

Apache License 2.0

11 stars 15 forks source link

Consistent suffix within context #672

Closed maximilianvoss closed 4 months ago

maximilianvoss commented 4 months ago

Description

For all templates the suffix only contains the path of the URL. For Cloudflare it is the complete URL which is not consistent

Related Issue

N/A

Motivation and Context

Having the same functions deployed everywhere and the context is consistent.

How Has This Been Tested?

local deployment & testing

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

trieloff commented 4 months ago

Looks good, but could you change the commit history so that at least one commit reads fix(cloudflare): suffix should not include full URL

We generate the release notes from the commit messages, so this is more than cosmetic.