search

adobe / helix-dispatch

A Helix microservice that retrieves content from multiple sources and delivers the best match
Apache License 2.0
4 stars 2 forks source link

Pass Extra Logging Header on to dispatched actions #232

Open trieloff opened 4 years ago

trieloff commented 4 years ago

From @mcorlan:

  • By default, successful blocking invocations will not produce an activation record, thus running "wsk activation list" will not list any of these. Logs are still recorded and can be retrieved using the activation ID - this is still being sent to the client invoking the action
  • Developers can force creating an activation record for successful blocking invocations by including this header X-OW-EXTRA-LOGGING: on in the request

See also:

we should make sure that this header is passed on to all invocations we make.

tripodsan commented 4 years ago

any particular reason why you want to keep the activation records?

trieloff commented 4 years ago

Not every application failure bubbles up as an action failure, so keeping some of the records can help with troubleshooting. When you are turning on X-Debug you generally want to get all available information, wherever it might be.

kptdobe commented 4 years ago

I would wait until we know what this really means for us (i.e. practice). I do not see the need if this is only about the list of successful runtime activations: we anyway duplicate everything in our logs (Coralogix) and in Epsagon. We'll see them somewhere.