search

adobe / helix-embed

Embed service for helix.
Apache License 2.0
5 stars 3 forks source link

Add SlideShare support #208

Closed rofe closed 4 years ago

rofe commented 4 years ago

Is your feature request related to a problem? Please describe. As a user, I would like to embed a SlideShare player in my content.

Describe the solution you'd like I add the SlideShare URL as a link in my md or Word doc, and Helix turns it into a SlideShare player for me.

Example: https://www.slideshare.net/adobe/adobe-digital-insights-holiday-recap-2019 would be transformed to the following output

<iframe src="//www.slideshare.net/slideshow/embed_code/key/dG2YdReopAurYT" width="595" height="485" frameborder="0" marginwidth="0" marginheight="0" scrolling="no" style="border:1px solid #CCC; border-width:1px; margin-bottom:5px; max-width: 100%;" allowfullscreen> </iframe>

Additional context Needed for https://github.com/adobe/theblog/issues/166

rofe commented 4 years ago

@MarquiseRosier is this something you would like to tackle?

MarquiseRosier commented 4 years ago

Sure thing! :)

rofe commented 4 years ago

My bad - this actually already works (thanks @trieloff!), we just need to whitelist slideshare.net in helix-pipeline https://github.com/adobe/helix-pipeline/issues/693

MarquiseRosier commented 4 years ago

^^ Oh yeah i just saw that! Ok.