search

adobe / helix-embed

Embed service for helix.
Apache License 2.0
5 stars 3 forks source link

Support player urls #218

Closed kptdobe closed 4 years ago

kptdobe commented 4 years ago

Follow up of the discussion here https://github.com/adobe/helix-pipeline/issues/702.

For any kind of embed, if the player url is provided (instead of the "direct" url to the resource), the embed service should be smart enough and use the player url as in the output.

MarquiseRosier commented 4 years ago

I’m interested in this! :)

MarquiseRosier commented 4 years ago

Reposting this, probably better here than in helix-chat

check https://iframely.com/features#domains to see what’s supported and just needs whitelisting! :D

kptdobe commented 4 years ago

What is the status with this issue ? theblog has pages with the vimeo player that are NOT turned into embeds: see https://theblog--adobe.hlx.page/en/drafts/migrated/2018/04/05/contributor-spotlight-pierre-le-cann.html