search

adobe / helix-embed

Embed service for helix.
Apache License 2.0
5 stars 3 forks source link

feat(embed.js): add embed type to class #232

Closed MarquiseRosier closed 4 years ago

MarquiseRosier commented 4 years ago

provide information about type of embed via the class attribute fix #211

Related Issues

211

Thanks for contributing!

github-actions[bot] commented 4 years ago

This PR will trigger a minor release when merged.

codecov[bot] commented 4 years ago

Codecov Report

Merging #232 into master will increase coverage by 0.08%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
+ Coverage   98.36%   98.44%   +0.08%     
==========================================
  Files           6        6              
  Lines         183      193      +10     
==========================================
+ Hits          180      190      +10     
  Misses          3        3
Impacted Files Coverage Δ
src/embed.js 95.31% <100.00%> (+0.66%) :arrow_up:
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7d4e71e...fa87bb1. Read the comment docs.

tripodsan commented 4 years ago

@MarquiseRosier are you still working on this?

MarquiseRosier commented 4 years ago

@tripodsan yes! :) I think this last commit should account for everyone's wants review comments :)

rofe commented 4 years ago

also handle cases like www.youtube.co.uk

It looks like links from www.youtube.co.uk are always openly redirected to www.youtube.com -at least from Switzerland :)

Are you able to actually capture a clip URL from www.youtube.co.jp in Japan?

tripodsan commented 4 years ago

also handle cases like www.youtube.co.uk

It looks like links from www.youtube.co.uk are always openly redirected to www.youtube.com -at least from Switzerland :)

Are you able to actually capture a clip URL from www.youtube.co.jp in Japan?

this was just an example.... I don't know if it's needed.

adobe-bot commented 4 years ago

:tada: This PR is included in version 1.4.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: