Closed MarquiseRosier closed 4 years ago
Description When importing from the original blog, we search iframes for the src: https://github.com/adobe/helix-theblog-importer/blob/b19ace2424399d68ccab30ec169b9360f1b811f2/src/index.js#L50-L121
The problem is these links don't work with our embed services; what we need is link to the original content not the link given in the src attribute of an . </p> <p>For example, these link cannot be embedded properly by Iframely but have been extracted during an import. </p> <p><strong>To Reproduce</strong> You can check them at <a rel="noreferrer nofollow" target="_blank" href="https://iframely.com/embed/">https://iframely.com/embed/</a>: </p> <p><a rel="noreferrer nofollow" target="_blank" href="https://embed.spotify.com/?uri=spotify4gzpq5DPGxSnKTe4SA8HAU">https://embed.spotify.com/?uri=spotify4gzpq5DPGxSnKTe4SA8HAU</a></p> <p><a rel="noreferrer nofollow" target="_blank" href="https://www.linkedin.com/video/embed/live/urn:li:ugcPost:6666809526391570432">https://www.linkedin.com/video/embed/live/urn:li:ugcPost:6666809526391570432</a></p> <p><a rel="noreferrer nofollow" target="_blank" href="https://w.soundcloud.com/player/?url=https%3A%2F%2Fapi.soundcloud.com%2Ftracks%2F673363193&color=%23ff5500&auto_play=false&hide_related=false&show_comments=true&show_user=true&show_reposts=false&show_teaser=true&visual=true">https://w.soundcloud.com/player/?url=https%3A%2F%2Fapi.soundcloud.com%2Ftracks%2F673363193&color=%23ff5500&auto_play=false&hide_related=false&show_comments=true&show_user=true&show_reposts=false&show_teaser=true&visual=true</a></p> <p><strong>Expected behavior</strong> these embeds should work; for every embed on the embed_allowlist in helix-pipeline, there should be a fallback that can get the right embed if we're given the link to src of a <iframe>, etc. This would require us to just visit the site and construct the embed ourselves!</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>
Description When importing from the original blog, we search iframes for the src: https://github.com/adobe/helix-theblog-importer/blob/b19ace2424399d68ccab30ec169b9360f1b811f2/src/index.js#L50-L121
The problem is these links don't work with our embed services; what we need is link to the original content not the link given in the src attribute of an