search

adobe / helix-embed

Embed service for helix.
Apache License 2.0
5 stars 3 forks source link

fix(embed.js): add title attribute to iframes #287

Closed MarquiseRosier closed 4 years ago

MarquiseRosier commented 4 years ago

this adds title attribute to iframes to boost accessibility. Additionally; it ensures that when helix embeds content that does not use iframes a span tag with a title attribute will be included

fix #286

Related Issues

286

Thanks for contributing!

codecov[bot] commented 4 years ago

Codecov Report

Merging #287 into master will increase coverage by 0.09%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
+ Coverage   98.56%   98.66%   +0.09%     
==========================================
  Files           7        7              
  Lines         209      224      +15     
==========================================
+ Hits          206      221      +15     
  Misses          3        3
Impacted Files Coverage Δ
src/embed.js 96.05% <100.00%> (+0.74%) :arrow_up:
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4568f93...b506080. Read the comment docs.

github-actions[bot] commented 4 years ago

This PR will trigger a patch release when merged.

rofe commented 4 years ago

@MarquiseRosier can this be merged?

adobe-bot commented 4 years ago

:tada: This PR is included in version 1.5.21 :tada:

The release is available on:

Your semantic-release bot :package::rocket: