adobe / helix-embed

Embed service for helix.
Apache License 2.0
5 stars 3 forks source link

feat(src/embed.js): ensures query params are added #322

Closed MarquiseRosier closed 4 years ago

MarquiseRosier commented 4 years ago

ensures query params make it to src attribute of iframe

fix #320

Please ensure your pull request adheres to the following guidelines:

Related Issues

Thanks for contributing!

codecov[bot] commented 4 years ago

Codecov Report

Merging #322 into master will increase coverage by 0.06%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #322      +/-   ##
==========================================
+ Coverage   98.68%   98.75%   +0.06%     
==========================================
  Files           7        7              
  Lines         228      240      +12     
==========================================
+ Hits          225      237      +12     
  Misses          3        3              
Impacted Files Coverage Δ
src/embed.js 96.66% <100.00%> (+0.46%) :arrow_up:
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f65d4da...6104c8c. Read the comment docs.

github-actions[bot] commented 4 years ago

This PR will trigger a minor release when merged.

adobe-bot commented 4 years ago

:tada: This PR is included in version 1.8.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: