adobe / helix-embed

Embed service for helix.

Apache License 2.0

5 stars 3 forks source link

fix(src/index.js): add timeout to fastly request #335

Closed MarquiseRosier closed 3 years ago

MarquiseRosier commented 3 years ago

currently request to fastly public-ip-list times out very frequently this leads to action failure as the container has a 6000ms timeout on generating an action response. This code adds timeout at 3000ms with action failure; after retries at 500ms timeout intervals.

fix #326

Please ensure your pull request adheres to the following guidelines:

[x] make sure to link the related issues in this description
[x] when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues

fix #326

Thanks for contributing!

github-actions[bot] commented 3 years ago

This PR will trigger a patch release when merged.

codecov[bot] commented 3 years ago

Codecov Report

Merging #335 (3d5e38d) into master (596a14f) will decrease coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #335      +/-   ##
==========================================
- Coverage   98.78%   98.76%   -0.03%     
==========================================
  Files           7        7              
  Lines         247      243       -4     
==========================================
- Hits          244      240       -4     
  Misses          3        3

Impacted Files	Coverage Δ
src/index.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 18902ef...3d5e38d. Read the comment docs.