search

adobe / helix-embed

Embed service for helix.
Apache License 2.0
5 stars 3 forks source link

Add source url to markup #514

Closed kptdobe closed 3 years ago

kptdobe commented 3 years ago

When providing a url to the service, some magic (oEmbed call) is used to transform that url into a player snippet for the corresponding service. When reading the returned markup: there is no way to know the source url.

Assuming our current ESI include issues will be fixed, this will be the next problem for importing the content from the HTML markup. To solve and assuming we'll get rid of this service after the Blog content will be "re-imported" and transformed into a block based content (vs "inline" and sections at the moment), I propose to add the source url as a data attribute of the parent div in the embed snippet. Like this, it is easy to find via a dom query and transform into the appropriate table.

@MarquiseRosier @tripodsan @trieloff WDYT ?

trieloff commented 3 years ago

:tada: This issue has been resolved in version 1.12.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: