Closed ghost closed 6 years ago
@kptdobe commented on Jul 5, 2018, 6:15 AM UTC:
3 first items done in adobe/helix-helpx#17
Main issue: neither hlx up
nor hlx build
builds the corresponding js file(s) into the .hlx/build
folder (just copies the html.htl
file in there)
I tried to run the following command manually, it still only copies the htl file only in the dist folder (as an htl file):
npx parcel build src/*.htl --target node
The html.pre.js
file is completely ignored.
@tripodsan @trieloff I am investigating but any hint would be great ;)
@kptdobe commented on Jul 5, 2018, 6:18 AM UTC:
I already noticed that @adobe/parcel-plugin-htl
is a "dependency" of the helix-cli project, not a "devDependency" as stated in the https://github.com/adobe/parcel-plugin-htl readme. But changing to devDependency does not solve my pb.
@kptdobe commented on Jul 5, 2018, 8:27 AM UTC:
Adding @adobe/parcel-plugin-htl
as a dev dependency of the helix-helpx project fixes the issue. I created #252 to track this as an improvement.
Almost ready, still blocked by https://github.com/adobe/petridish/issues/19
PR merged!
@kptdobe commented on Jul 4, 2018, 1:01 PM UTC:
Many things have changed in Helix and the sample helix-helpx project does not work anymore. Several things requires some changes (based on my understanding):
default.htl
template needs to be renamed tohtml.htl
default.pre.js
file needs to be renamed tohtml.pre.js
default.pre.js
must export apre
functiondefault.pre.js
must followpre
function guidelines (see https://github.com/adobe/parcel-plugin-htl/pull/13)This issue was moved by tripodsan from adobe/project-helix#249.