search

adobe / helix-home

The home of Project Helix
54 stars 84 forks source link

429 from Sharepoint propagated as 404 #150

Closed trieloff closed 4 years ago

trieloff commented 4 years ago

Somewhere in the content-proxy, pipeline, dispatch chain, a 429 gets turned into a 404, which may get cached by the outer cdn. Propagate it properly and we can cache the 429 in the outer cdn for a short time only.

@stefan-guggisberg

trieloff commented 4 years ago

https://helix.coralogix.com/#/query/logs?id=2tQO9j8YZWy

tripodsan commented 4 years ago

~hmm...it seems that this test is the same as the one above:~ ~https://github.com/adobe/helix-dispatch/blob/b8982b86e79d8201a36c106767d0709ad7e5f412/test/index.test.js#L510~

~IIRC, the idea was to test what happens if a /404.html returns a 429.~

forget the above... it's testing what happens if the ref returns a 429.

tripodsan commented 4 years ago

the utility in helix-shared turns it to a 503:

https://github.com/adobe/helix-shared/blob/2d87824491728a6343030613a081f107e47ab9b1/src/utils.js#L22-L37

stefan-guggisberg commented 4 years ago

Underlying issue: https://github.com/adobe/helix-word2md/issues/428

stefan-guggisberg commented 4 years ago

underlying issue adobe/helix-word2md#428 has been resolved, closing