adobe / helix-html-pipeline

A library for rendering the html response in Helix3.
https://www.hlx.live/
Apache License 2.0
13 stars 16 forks source link

Metadata Image URLs not rewritten #604

Closed bstopp closed 3 months ago

bstopp commented 4 months ago

Some metadata image URLs are not being rewritten to the production host domain.

Examples:

I believe that the URLs are not-rewritten if you set the image value explicitly in the metadata block.

tripodsan commented 4 months ago

I cannot reproduce it in tests, see: https://github.com/adobe/helix-html-pipeline/blob/d0c173f21942f6fb123ff6d4288364d4b9f0ec98/test/fixtures/content/image-from-meta-rewrite.html#L7

tripodsan commented 4 months ago

@bstopp the image in the metadata of merative is a link and not an image:

<https://main--merative2--hlxsites.hlx.page/images/meta/default-meta-image.png>
bstopp commented 4 months ago

the image in the metadata of merative is a link and not an image:

Yes, as is the one from Famous Smoke - because they wanted to use a shared image reference for all pages. But even as a link, it should be re-written to the live or production domain, as any other link.

github-actions[bot] commented 3 months ago

:tada: This issue has been resolved in version 5.11.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 3 months ago

:tada: This issue has been resolved in version 6.12.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: