search

adobe / helix-html2md

Service to convert Helix Generic HTML Content to Markdown.
Apache License 2.0
11 stars 12 forks source link

fix: add json-ld script handling #534

Closed maxakuru closed 1 week ago

maxakuru commented 3 weeks ago

fix #533

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (935bdfb) to head (7bfdf28). Report is 11 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #534 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 7 7 Lines 779 797 +18 Branches 1 1 ========================================= + Hits 779 797 +18 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 weeks ago

This PR will trigger a patch release when merged.

dylandepass commented 3 weeks ago

maybe we can add a limt... maybe 2k ?

I think 2k is going to be too restrictive. I just checked an example with one of our customers and the JSON LD for a Product was 14k.

maxakuru commented 3 weeks ago

AFAICS we also have no metadata size limits anywhere else for html2md? maybe it's enough that we limit the entire html string size to 1mb? https://github.com/adobe/helix-html2md/blob/main/src/index.js#L145