adobe / helix-importer-ui

Apache License 2.0
20 stars 25 forks source link

[Manual Mapping] Maintain the mapping for more than 1 URL in the localstorage. #354

Open atopper opened 1 month ago

atopper commented 1 month ago

Description

The mapping for 1 URL is deleted if the URL is changed, and a new mapping is started. Work can be lost easily this way. This change maintains multiple URls in the local storage

Eventually, perhaps, we should set a TTL of URL mappings. They could grow over time.

Related Issue

Motivation and Context

Ensure mappings are saved.

How Has This Been Tested?

Manually and ran tests.

Screenshots (if appropriate):

image

Types of changes

I'll say bug, although 'new feature' might apply.

Checklist:

atopper commented 1 month ago

@catalan-adobe @arumsey I can't seem to add reviewers (last of permission I assume), so hopefully this will bring it to your attention.

atopper commented 1 month ago

Do you think instead of the URL as the 'key', to use the hostname instead, so that any subpages are saved in the same mapping? Probably not needed for the pre-sales demo, but it is something that I keep wondering about.