fix: improve comments cleanup logic

adobe / helix-importer

Foundation tools for importing website content into that can be consumed in an Helix project.

Apache License 2.0

9 stars 18 forks source link

fix: improve comments cleanup logic #290

Closed kptdobe closed 10 months ago

kptdobe commented 10 months ago

While importing https://news.sap.com/2023/03/sap-cx-intelligent-industry-tailored-solutions/, @mhaack found a weird behaviour: content gets stripped out.

Root cause: page contains a ds-contextual-navigation web component with attribute last-visited-country="" <!--="". Of course attribute value breaks the comments cleanup logic (string regex based).

PR improves the regex and cleanup logic, even though I am not sure removing comments still matter now we are using a DOM element everywhere.

github-actions[bot] commented 10 months ago

:tada: This PR is included in version 3.1.4 :tada:

The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: