search

adobe / helix-labs-website

Apache License 2.0
0 stars 6 forks source link

Remove 'Scroll to Bottom' from import as service does not support it #41

Closed atopper closed 2 months ago

atopper commented 2 months ago

As per https://github.com/adobe/spacecat-api-service/pull/487#discussion_r1752547565, the option is not used.

Expected Behaviour

Only have the "Scroll to Bottom" checkbox if the service uses it.

Actual Behaviour

Apparently, the input is ignored, so do not present it to the user.

Reproduce Scenario (including but not limited to)

Run imports with it on and off - any differences?

Steps to Reproduce

Platform and Version

Sample Code that illustrates the problem

Logs taken while reproducing problem

atopper commented 2 months ago

The flag is still mentioned here (main code), so hesitating to pull it out too quickly.

atopper commented 2 months ago

Looks like both scrollToBottom and customHeaders are not (yet? Jira) supported by the service: https://github.com/adobe/spacecat-api-service/pull/494

arumsey commented 2 months ago

Looks like both scrollToBottom and customHeaders are not (yet? Jira) supported by the service: adobe/spacecat-api-service#494

customHeaders is no longer included in options object but as its own object instead which is already supported by the Bulk Import UI AFAIK.

arumsey commented 2 months ago

@atopper The only checkbox that should be exposed is enableJavascript then?

atopper commented 2 months ago

Since 1 checkbox in 'options' looks weird, I suggest moving 'timeout' to the Options as well (technically they make up the 'options' object): image